fix library-loading issues in editable installs #1484
Merged
+10
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#118
The pattern introduced in #1483 breaks editable installs in devcontainers. In that type of build,
libcuspatial.so
is built outside of the wheel but not installed, so it can't be found byld
. Extension modules incuspatial
are able to find it via RPATHs instead.This proposes:
adding an import of the(edit: removed those,cuspatial
Python library in thedevcontainers
CI job, as a smoke test to catch issues like this in the futuredevcontainer
builds run on CPU nodes)Notes for Reviewers
How I tested this
Tested this approach on rapidsai/kvikio#553
Checklist